Exclude csharp from performance test continuous runs.#26458
Merged
paulosjca merged 1 commit intogrpc:masterfrom Jun 10, 2021
Merged
Exclude csharp from performance test continuous runs.#26458paulosjca merged 1 commit intogrpc:masterfrom
paulosjca merged 1 commit intogrpc:masterfrom
Conversation
This is a workaround for a breakage introduced by grpc#22964.
jtattermusch
approved these changes
Jun 10, 2021
Contributor
jtattermusch
left a comment
There was a problem hiding this comment.
LGTM.
sorry for the breakage. I'll come up with a fix tomorrow.
gnossen
approved these changes
Jun 10, 2021
jtattermusch
added a commit
that referenced
this pull request
Jun 15, 2021
* Revert "Revert "Upgrade dotnet SDK 3 for C# build (#22964)" (#26462)" This reverts commit 736d914. * Revert "Exclude csharp from performance test continuous runs. (#26458)" This reverts commit 6744e8f. * switch remaining tests to C# buster image * remove C#'s global.json (which requires dotnet SDK 3+) * dotnet SDK3 currently breaks C# package build * regenerate dockerfiles
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a workaround for a breakage introduced by #22964.