[xDS interop] Updating the config update timeout to 600s#26213
Closed
lidizheng wants to merge 2 commits intogrpc:masterfrom
Closed
[xDS interop] Updating the config update timeout to 600s#26213lidizheng wants to merge 2 commits intogrpc:masterfrom
lidizheng wants to merge 2 commits intogrpc:masterfrom
Conversation
…00s (grpc#26090)" (grpc#26197)" This reverts commit cf7f5a0.
lidizheng
added
the
release notes: no
| success = False | ||
| if success: | ||
| logger.info('success') | ||
| return |
Contributor
There was a problem hiding this comment.
Won't this skip any remaining test cases?
Can we limit this PR to just the timeout changes and omit the structural changes (e.g., moving this into a while True block, pulling the attempts counter out of the per-test block) as these seem potentially error prone and can kind of be separated from the timeout change aspect of this?
Contributor
Author
|
Closed in favor of #26223. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Second attempt for #26090.
https://fusion2.corp.google.com/invocations/222be80b-0437-4040-ad98-cd74c49dfbcf/targets (a load_based_fail_over flake)
https://fusion2.corp.google.com/invocations/f7720619-8141-4342-b351-7506f79d57d6/targets (all green)