Merged
Conversation
stanley-cheung
added
lang/php
release notes: no
stanley-cheung
force-pushed
the
php-xds-user-agent
branch
from
faeb25d to
b3cfe89
Compare
stanley-cheung
force-pushed
the
php-xds-user-agent
branch
from
b3cfe89 to
26cdf41
Compare
stanley-cheung
force-pushed
the
php-xds-user-agent
branch
from
26cdf41 to
f0467c7
Compare
Contributor
Author
Rebased. Fresh set of tests will be running. |
stanley-cheung
force-pushed
the
php-xds-user-agent
branch
from
938147d to
3d53db3
Compare
apolcyn
reviewed
Jun 17, 2021
| -D_HAS_EXCEPTIONS=0 -DNOMINMAX -DGRPC_ARES=0 \ | ||
| -DGRPC_POSIX_FORK_ALLOW_PTHREAD_ATFORK=1) | ||
| -DGRPC_POSIX_FORK_ALLOW_PTHREAD_ATFORK=1 \ | ||
| -DGRPC_XDS_USER_AGENT_SUFFIX="\"PHP\"" \ |
Contributor
There was a problem hiding this comment.
I think this needs to actually be GRPC_XDS_USER_AGENT_NAME_SUFFIX
This typo may be related to #26496
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based off of #26189