Python packages: moving native symbol stripping to artifact phase.#26194
Merged
jtattermusch merged 1 commit intogrpc:masterfrom Sep 9, 2021
Merged
Python packages: moving native symbol stripping to artifact phase.#26194jtattermusch merged 1 commit intogrpc:masterfrom
jtattermusch merged 1 commit intogrpc:masterfrom
Conversation
jtattermusch
force-pushed
the
python_strip_in_artifacts
branch
from
893680a to
bb77ad4
Compare
Contributor
Author
jtattermusch
force-pushed
the
python_strip_in_artifacts
branch
from
bb77ad4 to
e408781
Compare
jtattermusch
force-pushed
the
python_strip_in_artifacts
branch
from
6f168c6 to
cca9d9e
Compare
jtattermusch
changed the title
jtattermusch
added
release notes: no
gnossen
approved these changes
Sep 8, 2021
Contributor
Author
|
The failed tests are all due to a kokoro job timeout (unrelated to this PR). |
ashithasantosh
pushed a commit
to ashithasantosh/grpc
that referenced
this pull request
Sep 10, 2021
lidizheng
pushed a commit
to lidizheng/grpc
that referenced
this pull request
Sep 23, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently symbol stripping for linux wheels is done in the "build_packages" phase. That has caused confusion in past releases (accidentally publishing non-stripped version of wheels).
This PR moves the stripping to the build_artifact phase:
Based on my experiments, the windows and macos wheels are already stripped (they are comparable in size to stripped linux wheels). For the crosscompiled wheels, we don't do any stripping, but that's no change with respect to the current state.