Describe status codes on the EventEngine API#26180
Merged
drfloob merged 5 commits intogrpc:masterfrom May 7, 2021
Merged
Conversation
drfloob
added
the
release notes: no
markdroth
reviewed
May 6, 2021
Member
markdroth
left a comment
markdroth
left a comment
There was a problem hiding this comment.
Only a few minor comments; overall, this looks good!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@markdroth
@nicolasnoble
This continues the work of ironing out EventEngine API details.
Note also that the
AcceptCallbackhas lost its status parameter. In short: that callback will never be called in non-OK situations - either CreateListener will fail, or itson_shutdowncallback will be called with an error status.Some of these changes also appear in PR #26026. For example, the addition of default destructors.