Increase artifact build timeout for windows-C##26179
Merged
drfloob merged 1 commit intogrpc:masterfrom May 6, 2021
Merged
Conversation
The 30min timeout has caused the multiarch artifact build to fail twice in the past week. See http://sponge2/55f7f6f8-d3c0-4b6e-91c8-c0c316f4717b
jtattermusch
approved these changes
May 6, 2021
Contributor
jtattermusch
left a comment
There was a problem hiding this comment.
LGTM. It's sad the the artifact builds are so slow.
Member
Author
|
It is a shame. In my ~6 months on this team I think I've had to increase the build timeouts 3 times now for various reasons. If it continues, we may want to prioritize making some improvements here. Thanks for the review. |
paulosjca
pushed a commit
to paulosjca/grpc
that referenced
this pull request
May 7, 2021
The 30min timeout has caused the multiarch artifact build to fail twice in the past week. See http://sponge2/55f7f6f8-d3c0-4b6e-91c8-c0c316f4717b
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 30min timeout has caused the multiarch artifact build to fail twice
in the past week. See http://sponge2/55f7f6f8-d3c0-4b6e-91c8-c0c316f4717b