Skip to content

Python simpler distribtests#26176

Merged
drfloob merged 3 commits intogrpc:masterfrom
jtattermusch:python_simpler_distribtests
May 7, 2021
Merged

Python simpler distribtests#26176
drfloob merged 3 commits intogrpc:masterfrom
jtattermusch:python_simpler_distribtests

Conversation

@jtattermusch
Copy link
Copy Markdown
Contributor

@jtattermusch jtattermusch commented May 5, 2021 •
edited
Loading

Currently running the artifacts - packages - distribtests flow needs to be done manually, it's a hassle to do it and it takes many hours for the flow to finish (and after that interpreting the results is involves lots of clicking on links in the test results).

Since as of now the python wheels built on linux are only tested by distribtests on linux, it is possible to run the entire python-specific artifact - package - distribtests flow for linux in a single kokoro job.

So this new job first builds python linux wheels (and source archives) and then tests them with distribtests in a single kokoro job.
Advantages:

  • the test results are easy to interpret
  • the job can run on PRs
  • the test script basically shows how to run the test python wheels with distribtest locally on dev's workstation.

@jtattermusch jtattermusch force-pushed the python_simpler_distribtests branch from 5d2fd2d to cb077e3 Compare May 6, 2021 12:06
@jtattermusch jtattermusch force-pushed the python_simpler_distribtests branch from cb077e3 to 53ab6c6 Compare May 6, 2021 12:54
@jtattermusch jtattermusch added the release notes: no Indicates if PR should not be in release notes label May 6, 2021
@jtattermusch jtattermusch requested a review from drfloob May 6, 2021 13:18
@jtattermusch
Copy link
Copy Markdown
Contributor Author

jtattermusch commented May 6, 2021

@lidizheng @gnossen @drfloob this is not fully ready to review, but the main idea is already there.

drfloob
drfloob reviewed May 6, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@drfloob drfloob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, Jan, thanks for putting it together. This job is only used for manual runs, right? Unless I'm mistaken there, it might be worth leaving a comment to that effect in the CI config file.

lidizheng
lidizheng reviewed May 6, 2021
View reviewed changes
@jtattermusch
Copy link
Copy Markdown
Contributor Author

jtattermusch commented May 7, 2021

This is an example of how the test results would look like (obtained by kidnapping another PR job temporarily):
https://source.cloud.google.com/results/invocations/d7628d85-6ecc-479e-bfa3-c9586ff4075d/targets

@jtattermusch jtattermusch force-pushed the python_simpler_distribtests branch from e3f7147 to a96ddea Compare May 7, 2021 12:19
@jtattermusch
Copy link
Copy Markdown
Contributor Author

jtattermusch commented May 7, 2021

I believe I've addressed all the comments and I also removed the "DO NOT MERGE" commit. This should now be ready for final review (and merge ;-) )

lidizheng
lidizheng approved these changes May 7, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@lidizheng lidizheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@drfloob drfloob merged commit 7d8a59c into grpc:master May 7, 2021
This was referenced Jun 24, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@drfloob drfloob drfloob approved these changes

+1 more reviewer

@lidizheng lidizheng lidizheng approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@drfloob drfloob

Labels

lang/Python release notes: no Indicates if PR should not be in release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jtattermusch @drfloob @lidizheng