@sanjaypujare Does this need to be backported to the v1.37.x branch as well?

Yes. Ideally we will mention a release tag to fetch the example and that will be a 1.37.n (it will have to be 1.37.2 when it does come out)

I don't think backporting it is necessary. Why can't we just have it work from head?

I don't think backporting it is necessary. Why can't we just have it work from head?

One issue is that master is not a permalink. The examples directory may move in the future.

Yes. Ideally we will mention a release tag to fetch the example and that will be a 1.37.n (it will have to be 1.37.2 when it does come out)

To the best of my knowledge, this example is the only thing that would require a patch release, which involves a full release of binary artifacts. Would it not be sufficient to just link to the v1.37.x branch? Alternatively, we could link to a specific commit.

I don't think backporting it is necessary. Why can't we just have it work from head?

We are going to document this in the UG and if the head changes (for whatever reason) we still want the documented examples links in the UG to work. The probability is very very small that head won't work can't be guaranteed.

To the best of my knowledge, this example is the only thing that would require a patch release, which involves a full release of binary artifacts. Would it not be sufficient to just link to the v1.37.x branch?

There are no release artifacts related to the v1.37.x branch but there are for an actual release like v1.37.1 and so on. With the artifacts you just download the zip file and be done with it. With a branch you will do a git clone?

With a branch you will do a git clone?

Branches, commits, and tags can all be downloaded from GitHub as zip/tarball over HTTP. For example:

https://github.com/grpc/grpc/archive/refs/heads/master.tar.gz
https://github.com/grpc/grpc/archive/9b87fb33bf61847ca05deb788532c2a182e93b26.tar.gz
https://github.com/grpc/grpc/archive/refs/tags/v1.37.1.tar.gz

My question was really about whether we really need to go through the whole patch release process for this?

My question was really about whether we really need to go through the whole patch release process for this?

No.

@yashykt Nice catch! Should be fixed now.

Known failures:

• build_artifact.csharp_ext_macos_ios Failure #26182
• build_artifact.csharp_ext_windows_x86 Timeout #26183