Fix grpc distribtests - broken virtualenv install#26154
Merged
drfloob merged 1 commit intogrpc:masterfrom May 4, 2021
Merged
Conversation
http://fusion/runanalysis/buildlogs/prod:grpc%2Fcore%2Fmaster%2Flinux%2Fgrpc_distribtests/prod:grpc%2Fcore%2Fmaster%2Flinux%2Fgrpc_distribtests/KOKORO/7d11a8e5-6930-4f30-9977-fca90bcb8312/1619778728188/prod:grpc%2Fcore%2Fmaster%2Flinux%2Fgrpc_distribtests%20build%20%2315492/Targets Note that the command `pip` fails after the upgrade since /usr/bin/pip is the OS default, and the (incompatible) upgrade is installed to /usr/local/bin/pip.
drfloob
added
area/test
lang/other
release notes: no
jtattermusch
reviewed
May 4, 2021
| RUN pip install virtualenv | ||
| RUN pip install --upgrade pip==19.3.1 | ||
|
|
||
| RUN /usr/local/bin/pip install virtualenv |
Contributor
There was a problem hiding this comment.
fair enough, but this probably deserves a comment (the pip vs /usr/local/bin/pip) part.
jtattermusch
approved these changes
May 4, 2021
Contributor
jtattermusch
left a comment
jtattermusch
left a comment
There was a problem hiding this comment.
LGTM with a comment. Let's make sure a new version of the image is uploaded to dockerhub.
Member
Author
|
Thanks Jan. After uploading the new docker image this morning (before your comment above), the build succeeded. I'll add the explanatory comment to the Dockerfile, push the new image to the repo, and merge this. |
Contributor
|
So adding the comment will be in a followup PR? |
Member
Author
|
Looks like I forgot to push that commit before I merged. Apologies. #26177 |
paulosjca
pushed a commit
to paulosjca/grpc
that referenced
this pull request
May 7, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See the breakage here: http://fusion/runanalysis/buildlogs/prod:grpc%2Fcore%2Fmaster%2Flinux%2Fgrpc_distribtests/prod:grpc%2Fcore%2Fmaster%2Flinux%2Fgrpc_distribtests/KOKORO/7d11a8e5-6930-4f30-9977-fca90bcb8312/1619778728188/prod:grpc%2Fcore%2Fmaster%2Flinux%2Fgrpc_distribtests%20build%20%2315492/Targets
Note that the command
pipfails after the upgrade since /usr/bin/pipis the OS default, and the (incompatible) upgrade is installed to
/usr/local/bin/pip.
Edit: This ran successfully after manually triggering
grpc_build_artifacts_multiplatform: http://fusion/runanalysis/info/prod:grpc%2Fcore%2Fexperimental%2Fgrpc_build_artifacts_multiplatform/prod:grpc%2Fcore%2Fexperimental%2Fgrpc_build_artifacts_multiplatform/KOKORO/224005eb-2222-4777-bc9d-0e4f70e046bd/1620076143416/build%20%231392/Targets