Skip to content

Enable Traffic Director time tracer#26111

Merged
lidizheng merged 1 commit intogrpc:masterfrom
lidizheng:td-trace
Apr 29, 2021
Merged

Enable Traffic Director time tracer#26111
lidizheng merged 1 commit intogrpc:masterfrom
lidizheng:td-trace

Conversation

@lidizheng
Copy link
Copy Markdown
Contributor

@lidizheng lidizheng commented Apr 28, 2021 •
edited
Loading

This PR enables TD's time trace which will yield useful information in CDS and LDS's metadata, WHEN a slow push arrived. The problem is, we might not be able to see that slow push, because if we waited the full amount of the 600s we fail the test case.

Do you think this will be a value-add to our xDS interop test? @ericgribkoff @menghanl

Here is the time trace proto:

https://source.corp.google.com/piper///depot/google3/loadbalancer/deputy/rcth/proto/envoyconfig-metadata.proto;rcl=370374111;l=225

Here is what we received:

            "metadata": {
                "filter_metadata": {
                  "TRAFFICDIRECTOR_LAST_CONFIG_UPDATE": {
                    "time": "2021-04-28T18:10:47.201825662+00:00"
                  },
                  "com.google.trafficdirector": {
                    "backend_service_name": "test-backend-service-0-lidiz"
                  }
                }
              },

This change is Reviewable

@lidizheng lidizheng added the release notes: no Indicates if PR should not be in release notes label Apr 28, 2021
@menghanl
Copy link
Copy Markdown
Contributor

menghanl commented Apr 28, 2021

This change LGTM.

In the test logs, where will this be printed? In the client logs when the client prints the received xDS responses?

@lidizheng
Copy link
Copy Markdown
Contributor Author

lidizheng commented Apr 28, 2021

@menghanl Yes. The additional time stamp will be printed in the client log, when our interop client received LDS or CDS update.

@lidizheng lidizheng merged commit 26ceb86 into grpc:master Apr 29, 2021
lidizheng added a commit to lidizheng/grpc that referenced this pull request May 17, 2021
@lidizheng
Enable Traffic Director time tracer (grpc#26111)
4f2fb9e
@lidizheng lidizheng mentioned this pull request May 17, 2021
Merged
lidizheng added a commit to lidizheng/grpc that referenced this pull request May 17, 2021
@lidizheng
Enable Traffic Director time tracer (grpc#26111)
b6f9115
This was referenced May 17, 2021
Merged
Merged
lidizheng added a commit that referenced this pull request May 17, 2021
@lidizheng
Enable Traffic Director time tracer (#26111)
81d38b3
lidizheng added a commit that referenced this pull request May 17, 2021
@lidizheng
Enable Traffic Director time tracer (#26111)
cd8c507
This was referenced May 17, 2021
Closed
Merged
lidizheng added a commit that referenced this pull request May 17, 2021
@lidizheng
Enable Traffic Director time tracer (#26111)
943d872
This was referenced May 17, 2021
Merged
Merged
lidizheng added a commit that referenced this pull request May 17, 2021
@lidizheng
Enable Traffic Director time tracer (#26111)
f6808bd
lidizheng added a commit that referenced this pull request May 17, 2021
@lidizheng
Enable Traffic Director time tracer (#26111)
dcdd311
@lidizheng lidizheng mentioned this pull request May 17, 2021
Merged
lidizheng added a commit that referenced this pull request May 17, 2021
@lidizheng
Enable Traffic Director time tracer (#26111)
790f354
@lidizheng lidizheng mentioned this pull request May 17, 2021
Merged
lidizheng added a commit that referenced this pull request May 17, 2021
@lidizheng
Enable Traffic Director time tracer (#26111)
5f8e471
@lidizheng lidizheng mentioned this pull request May 17, 2021
Merged
lidizheng added a commit that referenced this pull request May 19, 2021
@lidizheng @ericgribkoff @yashykt
Backport config update timeout change to v1.38.x (#26276)
667476e 
* Enable Traffic Director time tracer (#26111)

* Just update the timeout (#26223)

* Increase xds job timeouts (#26187)

* Revert grpc_xds_k8s job timeouts back to 120 mins (#26219)

* Revert grpc_xds_k8s_python timeout to 120mins (#26221)

Seems to have been inadvertently increased in #26187

Co-authored-by: Eric Gribkoff <[email protected]>
Co-authored-by: Yash Tibrewal <[email protected]>
lidizheng added a commit that referenced this pull request May 19, 2021
@lidizheng @ericgribkoff @yashykt
Backport config update timeout change to v1.37.x (#26275)
ad95315 
* Enable Traffic Director time tracer (#26111)

* Just update the timeout (#26223)

* Increase xds job timeouts (#26187)

* Revert grpc_xds_k8s job timeouts back to 120 mins (#26219)

* Revert grpc_xds_k8s_python timeout to 120mins (#26221)

Seems to have been inadvertently increased in #26187

Co-authored-by: Eric Gribkoff <[email protected]>
Co-authored-by: Yash Tibrewal <[email protected]>
lidizheng added a commit that referenced this pull request May 19, 2021
@lidizheng @ericgribkoff
Backport config update timeout change to v1.36.x (#26274)
929b516 
* Enable Traffic Director time tracer (#26111)

* Just update the timeout (#26223)

* Increase xds job timeouts (#26187)

Co-authored-by: Eric Gribkoff <[email protected]>
srini100 pushed a commit that referenced this pull request May 20, 2021
@lidizheng @ericgribkoff
Backport config update timeout change to v1.30.x (#26264)
d2cf489 
* Enable Traffic Director time tracer (#26111)

* Just update the timeout (#26223)

* Increase xds job timeouts (#26187)

* Update run_xds_tests.py

* Update run_xds_tests.py

Co-authored-by: Eric Gribkoff <[email protected]>
srini100 pushed a commit that referenced this pull request May 20, 2021
@lidizheng @ericgribkoff
Backport config update timeout change to v1.31.x (#26265)
ae06582 
* Enable Traffic Director time tracer (#26111)

* Just update the timeout (#26223)

* Increase xds job timeouts (#26187)

* Update run_xds_tests.py

Co-authored-by: Eric Gribkoff <[email protected]>
srini100 pushed a commit that referenced this pull request May 20, 2021
@lidizheng @ericgribkoff
Backport config update timeout change to v1.32.x (#26269)
8f73ad1 
* Enable Traffic Director time tracer (#26111)

* Just update the timeout (#26223)

* Increase xds job timeouts (#26187)

* Update run_xds_tests.py

Co-authored-by: Eric Gribkoff <[email protected]>
srini100 pushed a commit that referenced this pull request May 20, 2021
@lidizheng @ericgribkoff
Backport config update timeout change to v1.33.x (#26271)
d5a9c89 
* Enable Traffic Director time tracer (#26111)

* Just update the timeout (#26223)

* Increase xds job timeouts (#26187)

* Update run_xds_tests.py

Co-authored-by: Eric Gribkoff <[email protected]>
srini100 pushed a commit that referenced this pull request May 20, 2021
@lidizheng @ericgribkoff
Backport config update timeout change to v1.34.x (#26272)
3530b9c 
* Enable Traffic Director time tracer (#26111)

* Just update the timeout (#26223)

* Increase xds job timeouts (#26187)

Co-authored-by: Eric Gribkoff <[email protected]>
srini100 pushed a commit that referenced this pull request May 20, 2021
@lidizheng @ericgribkoff
Backport config update timeout change to v1.35.x (#26273)
cdb7efa 
* Enable Traffic Director time tracer (#26111)

* Just update the timeout (#26223)

* Increase xds job timeouts (#26187)

Co-authored-by: Eric Gribkoff <[email protected]>
apolcyn added a commit that referenced this pull request Jun 17, 2021
@apolcyn @yashykt
@drfloob @donnadionne @markdroth @lidizheng @ericgribkoff @jtattermusch
Upmerge 1.38.x (#26494)
f9d8524 
* Bump version to v1.38.0-pre1 (#26208)

* Bump version to v1.38.0-pre1

* Regenerate projects

* [Backport][v1.38.x] Add EventEngine's port.h to the podspec (#26222)

Backport of #26220 to v1.38.x. This is the only backport, since the EventEngine code was introduced after v1.37 was cut.

This file is needed for the Objective-C cocoapod build.

* fix xds resolver to add XdsClient to channel args even on errors (#26282) (#26288)

Co-authored-by: Mark D. Roth <[email protected]>

* Backport config update timeout change to v1.38.x (#26276)

* Enable Traffic Director time tracer (#26111)

* Just update the timeout (#26223)

* Increase xds job timeouts (#26187)

* Revert grpc_xds_k8s job timeouts back to 120 mins (#26219)

* Revert grpc_xds_k8s_python timeout to 120mins (#26221)

Seems to have been inadvertently increased in #26187

Co-authored-by: Eric Gribkoff <[email protected]>
Co-authored-by: Yash Tibrewal <[email protected]>

* Bump v1.38.x to v1.38.0  (#26317)

* Bump version to v1.38.0

* Regenerate projects

* Provide custom sponge configs to exclude manual runs from testgrid (#26283) (#26313)

* Provide custom sponge configs

* Correct the script

* Allow test scripts to produce artifacts through Docker

* Overcome the direcotry clone in our docker script

* Expose TESTGRID_EXCLUDE and GIT_ORIGIN_URL through docker run

* Make sanity tests happy

* Revert "Provide custom sponge configs to exclude manual runs from testgrid (#26283) (#26313)" (#26324)

This reverts commit 54dc182.

* better way of building protoc aarch64 artifacts (#26423)

* Backport #26430 and #26435 to v1.38.x (#26436)

* workaround #26279 at the expense of binary compatibility

* correctly tag aarch64 wheels as manylinux_2_24

* remove unnecessary comments left by #26430

* Backport #22964 into v1.38.x (#26448)

* upgrade dotnet SDK 3 for C# build

* add C# global.json

* install dotnet SDK 3 on macos

* upgrade C# docker images to debian buster

* regenerate dockerfiles

* Backport fixes from #26465 to v1.38.x (#26466)

* switch remaining tests to C# buster image

* remove C#'s global.json (which requires dotnet SDK 3+)

* dotnet SDK3 currently breaks C# package build

* regenerate dockerfiles

Co-authored-by: Yash Tibrewal <[email protected]>
Co-authored-by: AJ Heller <[email protected]>
Co-authored-by: donnadionne <[email protected]>
Co-authored-by: Mark D. Roth <[email protected]>
Co-authored-by: Lidi Zheng <[email protected]>
Co-authored-by: Eric Gribkoff <[email protected]>
Co-authored-by: Jan Tattermusch <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericgribkoff ericgribkoff Awaiting requested review from ericgribkoff

1 more reviewer

@menghanl menghanl menghanl approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@menghanl menghanl

@ericgribkoff ericgribkoff

Labels

release notes: no Indicates if PR should not be in release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lidizheng @menghanl @ericgribkoff