Skip to content

Grpc.Tools: Use x64 protoc on macOS arm64#26080

Merged
jtattermusch merged 1 commit intogrpc:masterfrom
BradBarnich:macOS-rosetta-arm64
May 6, 2021
Merged

Grpc.Tools: Use x64 protoc on macOS arm64#26080
jtattermusch merged 1 commit intogrpc:masterfrom
BradBarnich:macOS-rosetta-arm64

Conversation

@BradBarnich
Copy link
Copy Markdown
Contributor

@BradBarnich BradBarnich commented Apr 24, 2021

As a workaround until #25755 is resolved.

@markdroth

@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla bot commented Apr 24, 2021 •
edited
Loading

CLA Signed

The committers are authorized under a signed CLA.

@jtattermusch jtattermusch changed the title Use x64 protoc on macOS arm64 Grpc.Tools: Use x64 protoc on macOS arm64 May 4, 2021
@jtattermusch jtattermusch added the release notes: yes Indicates if PR needs to be in release notes label May 4, 2021
jtattermusch
jtattermusch suggested changes May 4, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@jtattermusch jtattermusch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the comments in the code.

@BradBarnich BradBarnich force-pushed the macOS-rosetta-arm64 branch from fe74579 to b33fbf5 Compare May 4, 2021 15:00
@BradBarnich
Copy link
Copy Markdown
Contributor Author

BradBarnich commented May 4, 2021

@jtattermusch Thank you, can you give this new version a look?

@BradBarnich BradBarnich requested a review from jtattermusch May 4, 2021 15:05
@jtattermusch
Copy link
Copy Markdown
Contributor

jtattermusch commented May 5, 2021

I started an adhoc run of package build and distribtest: https://fusion2.corp.google.com/invocations/6aedd5f1-57dc-443f-a335-f2320090f7e2/targets

I will post results later.

jtattermusch
jtattermusch approved these changes May 5, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@jtattermusch jtattermusch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once the tests are green and an adhoc build of Grpc.Tools is tested.

@jtattermusch
Copy link
Copy Markdown
Contributor

jtattermusch commented May 5, 2021

@apolcyn please add another Gooogler's review.

@jtattermusch
Copy link
Copy Markdown
Contributor

jtattermusch commented May 5, 2021

One more run of distribtests:
https://fusion2.corp.google.com/invocations/d7c3d66c-f92c-4a78-9bba-75f24fcde425/targets

@jtattermusch
Copy link
Copy Markdown
Contributor

jtattermusch commented May 6, 2021

Distribtests are green: https://fusion2.corp.google.com/invocations/7a23e587-b8cc-4512-a8dd-8ca0bcaecef3 (except of distribtest.python_linux_x64_ubuntu1604, which is unrelated and is being fixed).

@jtattermusch jtattermusch merged commit 9807b03 into grpc:master May 6, 2021
paulosjca pushed a commit to paulosjca/grpc that referenced this pull request May 7, 2021
@BradBarnich @paulosjca
Use x64 protoc on macOS arm64 (grpc#26080)
de8f36c
This was referenced Jan 3, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@apolcyn apolcyn apolcyn approved these changes

+1 more reviewer

@jtattermusch jtattermusch jtattermusch approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jtattermusch jtattermusch

Labels

lang/C# release notes: yes Indicates if PR needs to be in release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@BradBarnich @jtattermusch @apolcyn @grpc-kokoro