s/OnServingStatusChange/OnServingStatusUpdate#26010
Merged
yashykt merged 3 commits intogrpc:masterfrom Apr 26, 2021
Merged
Conversation
yashykt
added
release notes: yes
markdroth
approved these changes
Apr 21, 2021
Merged
Member
Author
|
Basic Tests Python Windows test has timed out, and seems unrelated to this change. |
yashykt
added a commit
to yashykt/grpc
that referenced
this pull request
Apr 26, 2021
* s/OnServingStatusChange/OnServingStatusUpdate * Update python files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renaming experimental API OnServingStatusChange to OnServingStatusUpdate to make it clearer that the callback will be invoked when the serving status has updates and not just explicit changes (from NOT_SERVING to SERVING or vice-versa). Also, noting that updates might be duplicates.