Skip to content

add test-only channel arg to set per-channel xDS bootstrap config#25936

Merged
markdroth merged 13 commits intogrpc:masterfrom
markdroth:xds_client_per_channel_for_tests
Apr 21, 2021
Merged

add test-only channel arg to set per-channel xDS bootstrap config#25936
markdroth merged 13 commits intogrpc:masterfrom
markdroth:xds_client_per_channel_for_tests

Conversation

@markdroth
Copy link
Copy Markdown
Member

No description provided.

@markdroth markdroth added the release notes: no Indicates if PR should not be in release notes label Apr 8, 2021
@markdroth markdroth marked this pull request as ready for review April 13, 2021 20:33
@markdroth markdroth requested a review from yashykt April 13, 2021 20:33
@markdroth
Copy link
Copy Markdown
Member Author

This is now ready for review.

CC @ejona86 @dfawley

@markdroth
Copy link
Copy Markdown
Member Author

The test failures here all look like infrastructure issues or unrelated flakes.

@markdroth
Copy link
Copy Markdown
Member Author

Known issues: #26042

The "Basic Tests Python Windows" failure is an infrastructure timeout.

@markdroth markdroth merged commit feff79a into grpc:master Apr 21, 2021
@markdroth markdroth deleted the xds_client_per_channel_for_tests branch April 21, 2021 17:16
yashykt pushed a commit to yashykt/grpc that referenced this pull request Apr 26, 2021
…pc#25936)

* pass XdsClient to LB policies via channel args

* add channel arg for overriding bootstrap config on a per-channel basis

* change tests to use new channel arg approach -- currently failing for server-side tests

* use the same channel args approach on the server side

* clang-format

* fix CircuitBreakingMultipleChannelsShareCallCounter test

* fix XdsEnabledServerTest test

* add TODO

* clang-format

* generate_projects

* fix clang-tidy

* fix build

* attempt to fix python
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release notes: no Indicates if PR should not be in release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants