xdsinterop: extend the ports to use#25881
Merged
menghanl merged 1 commit intogrpc:masterfrom Apr 6, 2021
Merged
Conversation
This is to add more ports for forwarding-rule. It's in theory not necessary, because forwarding-rule doesn't need to use the same port as the services. This is a limitation of the test framework, and can be fixed in the future.
menghanl
added
the
release notes: no
lidizheng
reviewed
Apr 5, 2021
Contributor
lidizheng
left a comment
lidizheng
left a comment
There was a problem hiding this comment.
Looks good, but why do we change tools/internal_ci/linux/grpc_python_bazel_test.cfg?
| build_file: "grpc/tools/internal_ci/linux/grpc_bazel.sh" | ||
| timeout_mins: 240 | ||
| build_file: "grpc/tools/internal_ci/linux/grpc_xds.sh" | ||
| timeout_mins: 180 |
Contributor
There was a problem hiding this comment.
This changes doesn't seem right. Maybe you wanted to create a new .cfg file?
Contributor
Author
There was a problem hiding this comment.
This is to hijack the python test to run the xds tests. Will revert the commit later.
| help='GCP network to use') | ||
| argp.add_argument('--service_port_range', | ||
| default='8080:8110', | ||
| default='8080:8280', |
Contributor
There was a problem hiding this comment.
optional: we can expand the port range to a much larger numbers. E.g., 1k? 50k?
Contributor
Author
There was a problem hiding this comment.
We can only use the ports allowed by the pre-configured firewall rule.
Contributor
There was a problem hiding this comment.
Oh, TIL. In that case, looks good.
lidizheng
approved these changes
Apr 5, 2021
Contributor
lidizheng
left a comment
lidizheng
left a comment
There was a problem hiding this comment.
Bazel Python passed, the test cases looks fine.
menghanl
force-pushed
the
xds_interop_more_ports
branch
from
a130edb to
58c2b9b
Compare
menghanl
added a commit
that referenced
this pull request
Apr 7, 2021
This is to add more ports for forwarding-rule. It's in theory not necessary, because forwarding-rule doesn't need to use the same port as the services. This is a limitation of the test framework, and can be fixed in the future.
menghanl
added a commit
to menghanl/grpc
that referenced
this pull request
Apr 7, 2021
This is to add more ports for forwarding-rule. It's in theory not necessary, because forwarding-rule doesn't need to use the same port as the services. This is a limitation of the test framework, and can be fixed in the future.
menghanl
added a commit
to menghanl/grpc
that referenced
this pull request
Apr 7, 2021
This is to add more ports for forwarding-rule. It's in theory not necessary, because forwarding-rule doesn't need to use the same port as the services. This is a limitation of the test framework, and can be fixed in the future.
menghanl
added a commit
to menghanl/grpc
that referenced
this pull request
Apr 7, 2021
This is to add more ports for forwarding-rule. It's in theory not necessary, because forwarding-rule doesn't need to use the same port as the services. This is a limitation of the test framework, and can be fixed in the future.
This was referenced Apr 7, 2021
menghanl
added a commit
to menghanl/grpc
that referenced
this pull request
Apr 7, 2021
This is to add more ports for forwarding-rule. It's in theory not necessary, because forwarding-rule doesn't need to use the same port as the services. This is a limitation of the test framework, and can be fixed in the future.
menghanl
added a commit
to menghanl/grpc
that referenced
this pull request
Apr 7, 2021
This is to add more ports for forwarding-rule. It's in theory not necessary, because forwarding-rule doesn't need to use the same port as the services. This is a limitation of the test framework, and can be fixed in the future.
This was referenced Apr 7, 2021
menghanl
added a commit
to menghanl/grpc
that referenced
this pull request
Apr 7, 2021
This is to add more ports for forwarding-rule. It's in theory not necessary, because forwarding-rule doesn't need to use the same port as the services. This is a limitation of the test framework, and can be fixed in the future.
menghanl
added a commit
to menghanl/grpc
that referenced
this pull request
Apr 7, 2021
This is to add more ports for forwarding-rule. It's in theory not necessary, because forwarding-rule doesn't need to use the same port as the services. This is a limitation of the test framework, and can be fixed in the future.
menghanl
added a commit
to menghanl/grpc
that referenced
this pull request
Apr 7, 2021
This is to add more ports for forwarding-rule. It's in theory not necessary, because forwarding-rule doesn't need to use the same port as the services. This is a limitation of the test framework, and can be fixed in the future.
menghanl
added a commit
to menghanl/grpc
that referenced
this pull request
Apr 7, 2021
This is to add more ports for forwarding-rule. It's in theory not necessary, because forwarding-rule doesn't need to use the same port as the services. This is a limitation of the test framework, and can be fixed in the future.
srini100
pushed a commit
that referenced
this pull request
Apr 8, 2021
srini100
pushed a commit
that referenced
this pull request
Apr 8, 2021
srini100
pushed a commit
that referenced
this pull request
Apr 8, 2021
srini100
pushed a commit
that referenced
this pull request
Apr 8, 2021
srini100
pushed a commit
that referenced
this pull request
Apr 8, 2021
srini100
pushed a commit
that referenced
this pull request
Apr 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to add more ports for forwarding-rule.
It's in theory not necessary, because forwarding-rule doesn't need to use the
same port as the services. This is a limitation of the test framework, and can
be fixed in the future.