Use Realtime instead of Monotonic time for CSDS#25857
Merged
lidizheng merged 1 commit intogrpc:masterfrom Apr 1, 2021
Merged
Conversation
lidizheng
added
lang/c++
release notes: no
Member
|
I don't understand what this means:
Can you please explain what the actual problem here is and how this PR fixes it? Thanks! |
Member
|
@markdroth |
markdroth
approved these changes
Apr 1, 2021
Member
markdroth
left a comment
markdroth
left a comment
There was a problem hiding this comment.
Ah, okay -- so the problem is that it converts to the wrong time. Makes sense.
Thanks for the fix, Lidi!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This needs a backport. Found by @menghanl.
After the update, the timestamp is back to normal instead of
"last_updated": "1970-01-21T22:53:48.202451705Z",.{ "config": [ { "node": { "id": "xds_end2end_test", "cluster": "test", "metadata": { "foo": "bar" }, "locality": { "region": "corp", "zone": "svl", "subZone": "mp3" }, "userAgentName": "gRPC C-core linux", "userAgentVersion": "15.0.0", "clientFeatures": [ "envoy.lb.does_not_support_overprovisioning" ] }, "xdsConfig": [ { "clusterConfig": { "versionInfo": "1", "dynamicActiveClusters": [ { "versionInfo": "1", "cluster": { "@type": "type.googleapis.com/envoy.config.cluster.v3.Cluster", "name": "cluster_name", "type": "EDS", "edsClusterConfig": { "edsConfig": { "ads": {} }, "serviceName": "eds_service_name" } }, "lastUpdated": "2021-03-31T22:39:41.965670143Z", "clientStatus": "ACKED" } ] } }, { "endpointConfig": { "dynamicEndpointConfigs": [ { "versionInfo": "1", "endpointConfig": { "@type": "type.googleapis.com/envoy.config.endpoint.v3.ClusterLoadAssignment", "clusterName": "eds_service_name", "endpoints": [ { "locality": { "region": "xds_default_locality_region", "zone": "xds_default_locality_zone", "subZone": "locality0" }, "lbEndpoints": [ { "endpoint": { "address": { "socketAddress": { "address": "127.0.0.1", "portValue": 19123 } } } } ], "loadBalancingWeight": 3 } ] }, "lastUpdated": "2021-03-31T22:39:41.976670220Z", "clientStatus": "ACKED" } ] } }, { "listenerConfig": { "versionInfo": "1", "dynamicListeners": [ { "name": "server.example.com", "activeState": { "versionInfo": "1", "listener": { "@type": "type.googleapis.com/envoy.config.listener.v3.Listener", "name": "server.example.com", "apiListener": { "apiListener": { "@type": "type.googleapis.com/envoy.extensions.filters.network.http_connection_manager.v3.HttpConnectionManager", "rds": { "configSource": { "ads": {} }, "routeConfigName": "route_config_name" }, "httpFilters": [ { "name": "router", "typedConfig": { "@type": "type.googleapis.com/envoy.extensions.filters.http.router.v3.Router" } } ] } } }, "lastUpdated": "2021-03-31T22:39:41.943670219Z" }, "clientStatus": "ACKED" } ] } }, { "routeConfig": { "dynamicRouteConfigs": [ { "versionInfo": "1", "routeConfig": { "@type": "type.googleapis.com/envoy.config.route.v3.RouteConfiguration", "name": "route_config_name", "virtualHosts": [ { "domains": [ "*" ], "routes": [ { "match": { "prefix": "" }, "route": { "cluster": "cluster_name" } } ] } ] }, "lastUpdated": "2021-03-31T22:39:41.954670206Z", "clientStatus": "ACKED" } ] } } ] } ] }This change is