Use URI form of address for channelz listen node#25785
Merged
yashykt merged 1 commit intogrpc:masterfrom Mar 23, 2021
Merged
Conversation
yashykt
force-pushed
the
channelzserveruri
branch
from
c08e874 to
bbd65aa
Compare
yashykt
changed the title
yashykt
added
the
release notes: yes
gnossen
approved these changes
Mar 23, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
grpc_sockaddr_to_string, we were losing information on the type of the resolved address when parsing the string as an URI, which resulted in the channelz node usingother_addressfield instead of formatting it as atcpip_address