testing: allow 10m for first xds fault_injection case#25779
testing: allow 10m for first xds fault_injection case#25779dfawley merged 1 commit intogrpc:masterfrom
Conversation
dfawley
added
the
release notes: no
lidizheng
left a comment
lidizheng
left a comment
There was a problem hiding this comment.
LGTM to reduce impact of infrastructure flake.
Do we need to apply this extensive timeout to the very first test case for entire xDS interop run?
I don't think so, unless we're seeing similar flakes with them. |
What's making fault_injection test special? I'm suspicious that if I put fault_injection test ahead of timeout test, then timeout test might be flaky. |
I think it might be the disabling of proxyless validation, which leads to the whole backend service being deleted and recreated. The timeout test doesn't do that. circuit_breaking does, but it has a couple wait_for_healthy_backends afterwords, which have 10m timeouts. |
4 participants
This may be enough to fix some of the flakiness we've been seeing.
If the deletion/recreation of the backend service (to disable proxyless validation) is excessively slow, this would help. The other test that does this, circuit breaking, has a 20m timer to wait for healthy backends afterwards.