Skip to content

xds: enable fault_injection xds tests for C++#25769

Merged
dfawley merged 1 commit intogrpc:masterfrom
dfawley:enable_fi_test
Mar 23, 2021
Merged

xds: enable fault_injection xds tests for C++#25769
dfawley merged 1 commit intogrpc:masterfrom
dfawley:enable_fi_test

Conversation

@dfawley
Copy link
Copy Markdown
Member

@dfawley dfawley commented Mar 19, 2021

No description provided.

@dfawley dfawley added the release notes: no Indicates if PR should not be in release notes label Mar 19, 2021
@dfawley dfawley requested a review from lidizheng March 19, 2021 17:44
@lidizheng
Copy link
Copy Markdown
Contributor

Should we wait for b/183066584?

@dfawley
Copy link
Copy Markdown
Member Author

dfawley commented Mar 22, 2021

Should we wait for b/183066584?

I'm fine to run this now. It's already enabled in Go and Java; we'll solve the flakiness for all 3 together (if #25779 doesn't fix it already).

@dfawley dfawley merged commit 55e3243 into grpc:master Mar 23, 2021
@dfawley dfawley deleted the enable_fi_test branch March 23, 2021 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release notes: no Indicates if PR should not be in release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants