Skip to content

Revert "Pin xDS interop test runner dependencies (#25665)"#25768

Merged
gnossen merged 1 commit intogrpc:masterfrom
gnossen:revert_25665
Mar 19, 2021
Merged

Revert "Pin xDS interop test runner dependencies (#25665)"#25768
gnossen merged 1 commit intogrpc:masterfrom
gnossen:revert_25665

Conversation

@gnossen
Copy link
Copy Markdown
Contributor

@gnossen gnossen commented Mar 19, 2021

Not all xDS interop images use the same version of Python 3. C#, for example, uses 3.5, while my manual run was on a job using 3.6. google-api-core 1.26.1 advertises 3.5 support with a badge on PyPi, but fails to install at that version. This is verifiable with the PyPi JSON API:

"requires_python": ">=2.7,!=3.0.*,!=3.1.*,!=3.2.*,!=3.3.*,!=3.4.*,!=3.5.*",

The next attempt at this will have to:

  • Pin dependencies according to the lowest common denominator Python version.
  • Trigger a lot of manual tests.

@gnossen gnossen added area/test release notes: no Indicates if PR should not be in release notes lang/all labels Mar 19, 2021
@gnossen gnossen requested a review from donnadionne March 19, 2021 17:34
@gnossen
Copy link
Copy Markdown
Contributor Author

gnossen commented Mar 19, 2021

Going ahead and merging since this is pure revert.

@gnossen gnossen merged commit ec40f07 into grpc:master Mar 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/test lang/all release notes: no Indicates if PR should not be in release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants