clang-format the examples/cpp directory#25764
Merged
vjpai merged 1 commit intogrpc:masterfrom Mar 22, 2021
Merged
Conversation
vjpai
added
lang/c++
lang/ObjC
release notes: no
vjpai
requested review from
apolcyn,
jtattermusch and
nicolasnoble
as code owners
jtattermusch
approved these changes
Mar 19, 2021
Contributor
jtattermusch
left a comment
jtattermusch
left a comment
There was a problem hiding this comment.
Approving to grant OWNERS approval.
I think @veblush is the best person to review the actual changes since he dealt with lots of c++ cleanup recently.
Contributor
Author
|
@jtattermusch Thanks for the review! Yes, I've assigned @veblush as the code reviewer for that reason. |
veblush
approved these changes
Mar 19, 2021
Contributor
veblush
left a comment
veblush
left a comment
There was a problem hiding this comment.
LGTM! Thank you for the clean-up!
|
GPR_ASSERT(ok); ok is false when called quickly. why? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the examples/cpp directory to the clang-format consistency check to make sure that the code looks right. Realized that this looks odd when I was working on some examples.