Fix const-ness of callback client read RPC requests#25763
Merged
vjpai merged 2 commits intogrpc:masterfrom Mar 19, 2021
Merged
Conversation
vjpai
added
lang/c++
release notes: no
Member
|
There seem to be a bunch of failing tests. |
Contributor
Author
|
Yeah, the last round failed because I forgot to update the golden_file for the code generator. I think it's fixed now. The tests that have completed so far are passing, at least. |
Contributor
Author
|
Green now! |
yashykt
approved these changes
Mar 19, 2021
Member
|
Does this need to be cherry-picked? |
Contributor
Author
|
Sure I'll send it through TGP just in case (it's unlikely that anyone is mocking this but you never know). I had set auto-merge on this so it's in, and I'm OOO on Friday but I can check in on it at some point. |
Contributor
Author
|
@yashykt Thanks for the review, and good call. There is one mocker. I'll send a cherry-pick. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We don't use 1-sided streaming much, so I never noticed this obvious mistake. I have confirmed that the server side is ok.