Skip to content

Fix invalid use of python's traceback.print_exc#25743

Merged
drfloob merged 1 commit intogrpc:masterfrom
drfloob:fix/25425-invalid-print_exc-usage
Mar 17, 2021
Merged

Fix invalid use of python's traceback.print_exc#25743
drfloob merged 1 commit intogrpc:masterfrom
drfloob:fix/25425-invalid-print_exc-usage

Conversation

@drfloob
Copy link
Copy Markdown
Member

@drfloob drfloob commented Mar 17, 2021

The exception is being interpreted as a limit (int) to cap the number
of stack trace entries to print.

https://docs.python.org/3/library/traceback.html#traceback.print_exc

Problem also appeared in #25704

Fixes #25425

@drfloob drfloob added lang/Python area/test release notes: no Indicates if PR should not be in release notes labels Mar 17, 2021
@drfloob drfloob enabled auto-merge (squash) March 17, 2021 17:17
@yulin-liang yulin-liang requested review from lidizheng and removed request for yulin-liang March 17, 2021 17:49
Copy link
Copy Markdown
Contributor

@lidizheng lidizheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@markdroth markdroth removed their request for review March 17, 2021 18:54
@drfloob drfloob merged commit 6ff0422 into grpc:master Mar 17, 2021
@drfloob drfloob deleted the fix/25425-invalid-print_exc-usage branch March 17, 2021 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/test lang/Python release notes: no Indicates if PR should not be in release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FLAKE: grpc/core/pull_request/macos/grpc_ios_binary_size[default]

2 participants