Skip to content

xds testing: set fault injection env var, so the test can be turned on#25735

Merged
menghanl merged 1 commit intogrpc:masterfrom
menghanl:turn_on_fault_injection_tests
Mar 17, 2021
Merged

xds testing: set fault injection env var, so the test can be turned on#25735
menghanl merged 1 commit intogrpc:masterfrom
menghanl:turn_on_fault_injection_tests

Conversation

@menghanl
Copy link
Copy Markdown
Contributor

This reverts #25676

Note that this doesn't turn on the tests. The tests needs to be turned on in the kokoro shell scripts.

…her repos

Note that this doesn't turn on the tests. The tests needs to be turned on in the kokoro shell scripts.
@menghanl
Copy link
Copy Markdown
Contributor Author

cc @donnadionne

@menghanl menghanl added the release notes: no Indicates if PR should not be in release notes label Mar 16, 2021
Copy link
Copy Markdown
Contributor

@lidizheng lidizheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manually confirmed that on HEAD with #25694 the interop test passes with and without --xds_v3_support flag.

@menghanl menghanl merged commit 74b767d into grpc:master Mar 17, 2021
@menghanl menghanl deleted the turn_on_fault_injection_tests branch March 17, 2021 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release notes: no Indicates if PR should not be in release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants