Skip to content

make Grpc C# work on aarch64 linux#25717

Merged
jtattermusch merged 9 commits intogrpc:masterfrom
jtattermusch:csharp_linux_aarch64
Mar 17, 2021
Merged

make Grpc C# work on aarch64 linux#25717
jtattermusch merged 9 commits intogrpc:masterfrom
jtattermusch:csharp_linux_aarch64

Conversation

@jtattermusch
Copy link
Copy Markdown
Contributor

@jtattermusch jtattermusch commented Mar 15, 2021 •
edited
Loading

Based on #25716

  • build aarch64 artifacts for both grpc_csharp_ext and codegen binaries
  • refactor and deduplicate code in platform detection in Grpc.Core and Grpc.Tools
  • update native extension loading logic in Grpc.Core to support Arm64
  • update Grpc.Tools to support Arm64

@jtattermusch jtattermusch added lang/C# release notes: yes Indicates if PR needs to be in release notes labels Mar 15, 2021
@jtattermusch jtattermusch force-pushed the csharp_linux_aarch64 branch from d74f800 to 14291e9 Compare March 16, 2021 09:27
@jtattermusch
Copy link
Copy Markdown
Contributor Author

jtattermusch commented Mar 16, 2021 •
edited
Loading

Adhoc build pacakges run: https://fusion2.corp.google.com/invocations/7b0f5087-6a2b-4dab-9ff0-58afa5d80836

Package build is passing, distribtests are also green (but note that at this point we don't have a ARM64 specific C# distribtest).

Adhoc packages can be downloaded here:
https://console.cloud.google.com/storage/browser/grpc-testing-kokoro-prod/test_result_public/prod/grpc/core/master/linux/grpc_build_packages/15975/20210316-052925

@jtattermusch jtattermusch requested a review from apolcyn March 16, 2021 09:33
@jtattermusch jtattermusch changed the title DRAFT: make Grpc C# work on aarch64 linux make Grpc C# work on aarch64 linux Mar 16, 2021
@jtattermusch jtattermusch marked this pull request as ready for review March 16, 2021 10:11
@jtattermusch
Copy link
Copy Markdown
Contributor Author

jtattermusch commented Mar 16, 2021 •
edited
Loading

Package size impact (mostly due to the added native binaries)

@jtattermusch jtattermusch merged commit 21c83cb into grpc:master Mar 17, 2021
@jtattermusch jtattermusch mentioned this pull request Mar 17, 2021
Closed
jtattermusch added a commit to jtattermusch/grpc that referenced this pull request Apr 4, 2021
@jtattermusch
remove dead code (followup for grpc#25717)
483c55e
jtattermusch added a commit to jtattermusch/grpc that referenced this pull request Apr 7, 2021
@jtattermusch
remove dead code (followup for grpc#25717)
f604fd5
jtattermusch added a commit that referenced this pull request Apr 20, 2021
@jtattermusch
Provide runtime/framework info in gRPC C# user agent string (#25889)
492e72a 
* remove dead code (followup for #25717)

* add more details into grpc-csharp user agent string

* address review comments
This was referenced Apr 22, 2021
Closed
Closed
@MD-V MD-V mentioned this pull request Apr 29, 2021
Closed
@jtattermusch jtattermusch added this to the ARM64 support milestone Jun 15, 2021
@MarsonShine MarsonShine mentioned this pull request Jul 1, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@apolcyn apolcyn apolcyn approved these changes

Assignees

@apolcyn apolcyn

Labels

lang/C# release notes: yes Indicates if PR needs to be in release notes

Projects

None yet

Milestone

ARM64 support

Development

Successfully merging this pull request may close these issues.

2 participants

@jtattermusch @apolcyn