Use crosscompilation to build python armv7 wheels#25704
Merged
jtattermusch merged 6 commits intogrpc:masterfrom Mar 17, 2021
Merged
Use crosscompilation to build python armv7 wheels#25704jtattermusch merged 6 commits intogrpc:masterfrom
jtattermusch merged 6 commits intogrpc:masterfrom
Conversation
jtattermusch
force-pushed
the
python_crosscompile_arm32_wheels
branch
from
750c67d to
959efdb
Compare
jtattermusch
added
release notes: yes
jtattermusch
changed the title
Contributor
Author
drfloob
reviewed
Mar 16, 2021
Member
drfloob
left a comment
drfloob
left a comment
There was a problem hiding this comment.
This is great, looks like you've found a way to cut down the build time significantly. A few small comments, otherwise looks good to me.
Contributor
Author
|
As a followup after this PR is merged, I think we should:
|
drfloob
approved these changes
Mar 17, 2021
gnossen
approved these changes
Mar 17, 2021
Contributor
gnossen
left a comment
gnossen
left a comment
There was a problem hiding this comment.
LGTM. The only thing that really needed much scrutiny from my perspective was the pyconfig.h copy. While I think there are other ways to achieve the same effect, it probably doesn't matter since this is all happening within a docker container.
Thanks for making this happen!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of building under an emulator (which takes 7 hours).