Skip to content

Added CMakeLists.txt to cpp/examples#25692

Merged
veblush merged 1 commit intogrpc:masterfrom
veblush:cmake-examples
Mar 18, 2021
Merged

Added CMakeLists.txt to cpp/examples#25692
veblush merged 1 commit intogrpc:masterfrom
veblush:cmake-examples

Conversation

@veblush
Copy link
Copy Markdown
Contributor

@veblush veblush commented Mar 11, 2021

Added the missing CMakeLists.txt to cpp/examples so that cmake can build all gRPC C++ examples. Once this is merged, we can remove makefiles and update the tutorial doc to use cmake instead of makefile.

@veblush veblush added release notes: no Indicates if PR should not be in release notes lang/c++ area/build labels Mar 11, 2021
@veblush veblush requested a review from jtattermusch March 11, 2021 19:55
@veblush veblush marked this pull request as ready for review March 11, 2021 19:55
Copy link
Copy Markdown
Contributor

@jtattermusch jtattermusch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@veblush veblush merged commit 343eb56 into grpc:master Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/build lang/c++ release notes: no Indicates if PR should not be in release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants