Skip to content

Pin xDS interop test runner dependencies#25665

Merged
gnossen merged 1 commit intogrpc:masterfrom
gnossen:pin_xds_interop_requirements
Mar 18, 2021
Merged

Pin xDS interop test runner dependencies#25665
gnossen merged 1 commit intogrpc:masterfrom
gnossen:pin_xds_interop_requirements

Conversation

@gnossen
Copy link
Copy Markdown
Contributor

@gnossen gnossen commented Mar 9, 2021

This should avoid future non-hermetic breakages.

Partially generated with

find tools/internal_ci/linux -name '*xds*sh' | \
  xargs sed -i \
    -e '/pip install.*grpcio-tools.*/c\\"\$PYTHON\" -m pip install -r tools/internal_ci/linux/xds_interop_dependencies/requirements.lock' \
    -e '/pip install.*pip.*/c\\"\$PYTHON\" -m pip install -r tools/internal_ci/linux/xds_interop_dependencies/pip.lock'

@gnossen gnossen added area/test lang/all release notes: no Indicates if PR should not be in release notes labels Mar 9, 2021
@gnossen
Copy link
Copy Markdown
Contributor Author

gnossen commented Mar 9, 2021 •
edited
Loading

Manual run with this PR. (failed, but this looks like it's for unrelated reasons -- dependency resolution worked just fine)

@gnossen gnossen requested a review from menghanl March 9, 2021 23:22
@gnossen gnossen marked this pull request as ready for review March 9, 2021 23:22
@gnossen
Copy link
Copy Markdown
Contributor Author

gnossen commented Mar 18, 2021

Unrelated Failure: #25665

@gnossen gnossen merged commit 7cf91c7 into grpc:master Mar 18, 2021
@gnossen gnossen deleted the pin_xds_interop_requirements branch March 18, 2021 22:20
gnossen added a commit to gnossen/grpc that referenced this pull request Mar 19, 2021
@gnossen
Revert "Pin xDS interop test runner dependencies (grpc#25665)"
2744dd1 
This reverts commit 7cf91c7.
gnossen added a commit that referenced this pull request Mar 19, 2021
@gnossen
Revert "Pin xDS interop test runner dependencies (#25665)" (#25768)
ec40f07 
This reverts commit 7cf91c7.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@menghanl menghanl menghanl approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@menghanl menghanl

Labels

area/test lang/all release notes: no Indicates if PR should not be in release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gnossen @menghanl