Merged
Conversation
iinozemtsev
requested review from
apolcyn,
jtattermusch and
nicolasnoble
as code owners
jtattermusch
added
the
release notes: no
Contributor
|
I pushed the updated docker image and restarted the interop tests. |
jtattermusch
approved these changes
Mar 9, 2021
Contributor
jtattermusch
left a comment
jtattermusch
left a comment
There was a problem hiding this comment.
LGTM once the tests are green.
Contributor
|
The http2 docker image build issue is unrelated https://source.cloud.google.com/results/invocations/ee9a0765-1825-48a7-ad8e-e1c4156e168f/targets/github%2Fgrpc%2Finterop_docker_build/tests Merging to fix the dart interop build issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@stanley-cheung this should fix #25652.
Tried
tools/run_tests/run_interop_tests.py -l dart -s java --use_dockerlocally and it fails before this change and passes after this change