Revert "Revert "Adding xxhash as a subtree""#25645
Conversation
|
there's a bunch of failures and you'll also need a passing adhoc artifacts - packages - distribtest (distribtests were broken the last time) run before this can go in (see bullet point 2 here: https://github.com/grpc/grpc/tree/master/third_party#checklist-for-adding-a-new-third-party-dependency) |
c893162 to
edcf2d5
Compare
|
That build seemed stuck for some reason, so I started another one https://sponge2.corp.google.com/e5a04e01-2ed9-4776-976f-528021b103ae |
edcf2d5 to
02fca4e
Compare
|
Linux and windows run from the previous ad-hoc run passed: mac run encountered "Tools failures" from previous ad-hoc runs; triggered another one after synching: The latest ad-hoc run passed! |
|
Known issues: #25660 (interop test failures) |
|
kokoro failure: due to unable to access the commitsha that is not yet submitted |
|
All Required tests pass; failed test have explainations. This is really the same change as last week; just now it's ready to be imported. PTAL thank you! |
|
Following through the chained jobs, the python-dev distribtests are failing: |
|
FTR, as discussed I think the issue with python-dev distribtests is that the python "sdist" archive is missing the newly added xxhash.h header: https://pantheon.corp.google.com/storage/browser/_details/grpc-testing-kokoro-prod/test_result_public/prod/grpc/core/master/linux/grpc_build_artifacts/16172/20210309-131926/github/grpc/artifacts/python_manylinux2010_x86_cp38-cp38/grpcio-1.37.0.dev0.tar.gz (and indeed, if you open the archive you'll see that third_party/xxhash/xxhash.h is not there). Made a one line change in setup.py (similar fix as #24450: to allow grpcio to build with xxhash), re-running adhoc to test it out: This was not the right fix; setup.py restored now |
07aa917 to
59c5010
Compare
59c5010 to
eaf0e69
Compare
|
Updated PYTHON-MANIFEST.in which fixed the grpc/core/experimental/grpc_distribtests_multiplatform: grpc/core/master/linux/grpc_distribtests: |
|
Known issues: #25660 (interop test failures) Ruby Failue is just a timeout, and this test has passed in previous runs before the 1 line change for Python. |
jtattermusch
left a comment
There was a problem hiding this comment.
LGTM (assuming you've tried the cherrypick into google3 and it worked fine).
Adding xxhash as a subtree
Attempting to submit the same code after taking care of import issues.