Skip to content

[Backport] Update the way dockerfiles install pip for python 2.7 and 3.5#25607

Merged
lidizheng merged 2 commits intogrpc:v1.36.xfrom
lidizheng:v1.36.x
Mar 4, 2021
Merged

[Backport] Update the way dockerfiles install pip for python 2.7 and 3.5#25607
lidizheng merged 2 commits intogrpc:v1.36.xfrom
lidizheng:v1.36.x

Conversation

@lidizheng
Copy link
Copy Markdown
Contributor

@lidizheng lidizheng commented Mar 3, 2021

Backport #25333 to v1.36.x

@lidizheng lidizheng added the release notes: no Indicates if PR should not be in release notes label Mar 3, 2021
Copy link
Copy Markdown
Contributor

@jtattermusch jtattermusch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for doing this!

@jtattermusch
Copy link
Copy Markdown
Contributor

Bazel build reports:

src/core/lib/iomgr/exec_ctx.cc:75:11: error: implicit conversion from 'long' to 'double' changes value from 9223372036854775807 to 9223372036854775808 [-Werror,-Wimplicit-int-float-conversion]
  if (x > GRPC_MILLIS_INF_FUTURE) return GRPC_MILLIS_INF_FUTURE;
        ~ ^~~~~~~~~~~~~~~~~~~~~~
./src/core/lib/iomgr/exec_ctx.h:39:32: note: expanded from macro 'GRPC_MILLIS_INF_FUTURE'
#define GRPC_MILLIS_INF_FUTURE INT64_MAX
                               ^~~~~~~~~
/usr/include/stdint.h:163:22: note: expanded from macro 'INT64_MAX'
# define INT64_MAX              (__INT64_C(9223372036854775807))
                                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/stdint.h:145:24: note: expanded from macro '__INT64_C'
#  define __INT64_C(c)  c ## L
                        ^~~~~~
<scratch space>:320:1: note: expanded from here
9223372036854775807L
^~~~~~~~~~~~~~~~~~~~
2 errors generated.
INFO: Elapsed time: 113.138s, Critical Path: 21.30s
INFO: 1268 processes: 223 internal, 1045 processwrapper-sandbox.
FAILED: Build did NOT complete successfully

I think you'll need to backport #24775 as well (see comments on the original PR #25333 ).

@lidizheng lidizheng enabled auto-merge (squash) March 4, 2021 21:09
@lidizheng lidizheng merged commit c3438a0 into grpc:v1.36.x Mar 4, 2021
gnossen added a commit that referenced this pull request Mar 24, 2021
* Bump version to 1.36.0-pre1

* Regenerate projects

* update dotnet sdk5 docker image to avoid nuget download error

* Merge pull request #25456 from gnossen/fix_interop_breakage

Bump xDS Interop Tests to Python 3

* Backport #25490 into v1.36.x (#25506)

* add IsNet5OrHigher to PlatformApis

* use explicit native library loading whenever possible

* Bump version to v1.36.0 (#25534)

* add env var protection for google-c2p resolver (#25548) (#25569)

* Bump version to 1.36.1 (#25574)

* Relax ruby test check on protobuf error message (#25507) (#25591)

Co-authored-by: apolcyn <[email protected]>

* [Backport] Update the way dockerfiles install pip for python 2.7 and 3.5 (#25607)

* Backport: Update the way dockerfiles install pip for python 2.7 and 3.5

* Fix implicit-int-float-conversion warning.

Co-authored-by: Jan Tattermusch <[email protected]>
Co-authored-by: Levon Ter-Grigoryan <[email protected]>

* Backport #25647 and #25510 (#25664)

* Fix pypa link (#25647)

* Fix pypa link

* And 3.5 as well

* [xDS Proto] Pin PyPI dependencies in Dockerfiles (#25510)

* Regenerate projects

Co-authored-by: Lidi Zheng <[email protected]>

* Fix an infinite read loop with SRV record resolution on windows (#25690)

* Bump version to 1.36.4 (#25744)

Co-authored-by: Lidi Zheng <[email protected]>
Co-authored-by: Jan Tattermusch <[email protected]>
Co-authored-by: Jan Tattermusch <[email protected]>
Co-authored-by: Mark D. Roth <[email protected]>
Co-authored-by: apolcyn <[email protected]>
Co-authored-by: Levon Ter-Grigoryan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lang/Python release notes: no Indicates if PR should not be in release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants