C#: Use explicit native extension loading whenever possible#25490
Merged
jtattermusch merged 2 commits intogrpc:masterfrom Feb 19, 2021
Merged
C#: Use explicit native extension loading whenever possible#25490jtattermusch merged 2 commits intogrpc:masterfrom
jtattermusch merged 2 commits intogrpc:masterfrom
Conversation
jtattermusch
added
lang/C#
release notes: yes
Contributor
Author
|
CC @jskeet |
Contributor
Author
jtattermusch
force-pushed
the
fix_loading_native
branch
from
4b5c170 to
ab1dd20
Compare
Contributor
Author
|
One more adhoc run of packages/distribtests: https://fusion2.corp.google.com/invocations/03d594b8-1240-43e2-9cb3-b505e14318fc/targets |
Contributor
Author
jtattermusch
commented
Feb 18, 2021
| // are similarly copied to the built output folder, through the magic of Microsoft.NETCore.Platforms. | ||
| var classicPath = Path.Combine(assemblyDirectory, GetNativeLibraryFilename()); | ||
|
|
||
| // With dotnet SDK project targeting netcoreappX.Y, projects will use Grpc.Core assembly directly in the location where it got restored |
Contributor
Author
There was a problem hiding this comment.
Contributor
Author
|
The adhoc build of nugets is here: @jskeet do you want to test the nugets and see if that fixes the problems you've encountered? All the distribtests seem to be passing. |
Contributor
|
I'll do a test tomorrow, thanks. |
apolcyn
approved these changes
Feb 18, 2021
Contributor
|
My specific "hang test" worked, as did the smoke tests for an actual API - great! Thanks very much :) |
This was referenced Feb 19, 2021
lidizheng
pushed a commit
that referenced
this pull request
Feb 19, 2021
gnossen
added a commit
that referenced
this pull request
Mar 24, 2021
* Bump version to 1.36.0-pre1 * Regenerate projects * update dotnet sdk5 docker image to avoid nuget download error * Merge pull request #25456 from gnossen/fix_interop_breakage Bump xDS Interop Tests to Python 3 * Backport #25490 into v1.36.x (#25506) * add IsNet5OrHigher to PlatformApis * use explicit native library loading whenever possible * Bump version to v1.36.0 (#25534) * add env var protection for google-c2p resolver (#25548) (#25569) * Bump version to 1.36.1 (#25574) * Relax ruby test check on protobuf error message (#25507) (#25591) Co-authored-by: apolcyn <[email protected]> * [Backport] Update the way dockerfiles install pip for python 2.7 and 3.5 (#25607) * Backport: Update the way dockerfiles install pip for python 2.7 and 3.5 * Fix implicit-int-float-conversion warning. Co-authored-by: Jan Tattermusch <[email protected]> Co-authored-by: Levon Ter-Grigoryan <[email protected]> * Backport #25647 and #25510 (#25664) * Fix pypa link (#25647) * Fix pypa link * And 3.5 as well * [xDS Proto] Pin PyPI dependencies in Dockerfiles (#25510) * Regenerate projects Co-authored-by: Lidi Zheng <[email protected]> * Fix an infinite read loop with SRV record resolution on windows (#25690) * Bump version to 1.36.4 (#25744) Co-authored-by: Lidi Zheng <[email protected]> Co-authored-by: Jan Tattermusch <[email protected]> Co-authored-by: Jan Tattermusch <[email protected]> Co-authored-by: Mark D. Roth <[email protected]> Co-authored-by: apolcyn <[email protected]> Co-authored-by: Levon Ter-Grigoryan <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tentatively fixes the hang issue described in #25208.
The problem is a side effect of #24744.