Bump xDS Interop Tests to Python 3#25456
Merged
gnossen merged 1 commit intogrpc:masterfrom Feb 16, 2021
Merged
Conversation
gnossen
changed the title
gnossen
added
the
release notes: no
Contributor
Author
menghanl
approved these changes
Feb 16, 2021
Contributor
|
Thanks a lot for the fix. We will need to backport this to the release branches. |
Contributor
Author
That depends on how the test runner code has changed over time. I seem to remember that the internal version was running on 3.4 at one point, so I think this will probably just work for all branches, but if not, it might require a little massaging. |
gnossen
added a commit
that referenced
this pull request
Feb 16, 2021
Bump xDS Interop Tests to Python 3
gnossen
added a commit
that referenced
this pull request
Feb 16, 2021
Bump xDS Interop Tests to Python 3
This was referenced Feb 16, 2021
gnossen
added a commit
that referenced
this pull request
Feb 16, 2021
Bump xDS Interop Tests to Python 3
gnossen
added a commit
that referenced
this pull request
Feb 16, 2021
Bump xDS Interop Tests to Python 3
gnossen
added a commit
that referenced
this pull request
Feb 16, 2021
Bump xDS Interop Tests to Python 3
gnossen
added a commit
that referenced
this pull request
Feb 16, 2021
Bump xDS Interop Tests to Python 3
gnossen
added a commit
that referenced
this pull request
Feb 16, 2021
Bump xDS Interop Tests to Python 3
gnossen
added a commit
that referenced
this pull request
Feb 16, 2021
Bump xDS Interop Tests to Python 3
gnossen
added a commit
that referenced
this pull request
Feb 16, 2021
Bump xDS Interop Tests to Python 3
gnossen
added a commit
that referenced
this pull request
Feb 16, 2021
Bump xDS Interop Tests to Python 3
gnossen
added a commit
that referenced
this pull request
Feb 16, 2021
Bump xDS Interop Tests to Python 3
gnossen
added a commit
that referenced
this pull request
Feb 16, 2021
Bump xDS Interop Tests to Python 3
This was referenced Feb 16, 2021
gnossen
added a commit
that referenced
this pull request
Mar 24, 2021
* Bump version to 1.36.0-pre1 * Regenerate projects * update dotnet sdk5 docker image to avoid nuget download error * Merge pull request #25456 from gnossen/fix_interop_breakage Bump xDS Interop Tests to Python 3 * Backport #25490 into v1.36.x (#25506) * add IsNet5OrHigher to PlatformApis * use explicit native library loading whenever possible * Bump version to v1.36.0 (#25534) * add env var protection for google-c2p resolver (#25548) (#25569) * Bump version to 1.36.1 (#25574) * Relax ruby test check on protobuf error message (#25507) (#25591) Co-authored-by: apolcyn <[email protected]> * [Backport] Update the way dockerfiles install pip for python 2.7 and 3.5 (#25607) * Backport: Update the way dockerfiles install pip for python 2.7 and 3.5 * Fix implicit-int-float-conversion warning. Co-authored-by: Jan Tattermusch <[email protected]> Co-authored-by: Levon Ter-Grigoryan <[email protected]> * Backport #25647 and #25510 (#25664) * Fix pypa link (#25647) * Fix pypa link * And 3.5 as well * [xDS Proto] Pin PyPI dependencies in Dockerfiles (#25510) * Regenerate projects Co-authored-by: Lidi Zheng <[email protected]> * Fix an infinite read loop with SRV record resolution on windows (#25690) * Bump version to 1.36.4 (#25744) Co-authored-by: Lidi Zheng <[email protected]> Co-authored-by: Jan Tattermusch <[email protected]> Co-authored-by: Jan Tattermusch <[email protected]> Co-authored-by: Mark D. Roth <[email protected]> Co-authored-by: apolcyn <[email protected]> Co-authored-by: Levon Ter-Grigoryan <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates all xDS interop tests to run the test runner on a Python 3.X interpreter. The build was recently broken when a minor version release of the
rsapackage (a transitive dependency) dropped support for Python 2.7. Theoretically, this bump in interpreter version is all that should be required, but it's possible that there's some incompatibility between the new interpreter version and the test runner code.I won't merge until my manual test finishes, but it looks promising, so I want to get presubmits running.
Generated with:
find tools/internal_ci/linux/ -name '*xds*docker*sh' | xargs sed -i 's/virtualenv "\$VIRTUAL_ENV"/virtualenv "\$VIRTUAL_ENV" -p python3/g'