Skip to content

Removing redundant files from upb yaml#25312

Merged
veblush merged 2 commits intogrpc:masterfrom
veblush:upb-dedup
Feb 2, 2021
Merged

Removing redundant files from upb yaml#25312
veblush merged 2 commits intogrpc:masterfrom
veblush:upb-dedup

Conversation

@veblush
Copy link
Copy Markdown
Contributor

@veblush veblush commented Jan 30, 2021

Files introduced from both upb and google_api_upb appear to be duplicate so it could cause a potential linking error.

Fixes: #25301

@veblush veblush added kind/bug lang/core release notes: no Indicates if PR should not be in release notes labels Jan 30, 2021
@veblush veblush requested a review from markdroth January 30, 2021 01:50
@veblush
Copy link
Copy Markdown
Contributor Author

veblush commented Feb 1, 2021

grpc_build_artifacts_multiplatform: passed except distribtest.csharp_linux_x64_dotnet5_dotnetcli failed due to external flakiness.

@veblush veblush merged commit 0f64ada into grpc:master Feb 2, 2021
@veblush veblush deleted the upb-dedup branch February 2, 2021 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/bug lang/core release notes: no Indicates if PR should not be in release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

multiple definition link time error on some upb symbols

2 participants