Update third_party/benchmark to v1.5.2#25184
Merged
veblush merged 1 commit intogrpc:masterfrom Mar 10, 2021
Merged
Conversation
|
|
Contributor
Author
|
@markdroth @veblush it's a trivial bump :) |
Member
|
@nicolasnoble, can you please take a look at this? Thanks! |
veblush
added
release notes: no
Contributor
Author
|
Are these failing tests criticals ? |
Contributor
|
@clementperon Thanks for the PR. This needs additional change to pass the sanity check. (doc would be helpful to understand what's needed) You need to changes in |
This fix the following error when compiling: error: #error C++11 or greater detected by the library. BENCHMARK_HAS_CXX11 is defined. 12 | #error C++11 or greater detected by the library. BENCHMARK_HAS_CXX11 is defined. | ^~~~~ Signed-off-by: Clément Péron <[email protected]>
clementperon
requested review from
gnossen,
jtattermusch,
nicolasnoble and
veblush
as code owners
Contributor
Author
|
@veblush Done ! I have compute the sha256sum by myself on my computer. not sure where i can find it... |
Contributor
Author
|
@jtattermusch thanks all pass :) |
Contributor
|
It looks good! Thank you! |
veblush
approved these changes
Mar 6, 2021
Contributor
|
@jtattermusch One more approval please. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix the following error when compiling:
error: #error C++11 or greater detected by the library. BENCHMARK_HAS_CXX11 is defined.
12 | #error C++11 or greater detected by the library. BENCHMARK_HAS_CXX11 is defined.
| ^~~~~
@markdroth