Skip to content

Python Circuit Breaking Interop Test Client Additions#25142

Merged
gnossen merged 7 commits intogrpc:masterfrom
gnossen:cb_interop_python
Jan 13, 2021
Merged

Python Circuit Breaking Interop Test Client Additions#25142
gnossen merged 7 commits intogrpc:masterfrom
gnossen:cb_interop_python

Conversation

@gnossen
Copy link
Copy Markdown
Contributor

@gnossen gnossen commented Jan 13, 2021

Implemented according to the interop client spec.

@gnossen gnossen added lang/Python area/test release notes: no Indicates if PR should not be in release notes labels Jan 13, 2021
Copy link
Copy Markdown
Contributor

@lidizheng lidizheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, LGTM with some stylish comments.

Copy link
Copy Markdown
Contributor

@voidzcy voidzcy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM. Nice job.

@ericgribkoff ericgribkoff removed their request for review January 13, 2021 05:25
@gnossen
Copy link
Copy Markdown
Contributor Author

gnossen commented Jan 13, 2021

Interop ALTS failure: #25149

@gnossen gnossen merged commit 4ea16b6 into grpc:master Jan 13, 2021
@gnossen gnossen deleted the cb_interop_python branch January 13, 2021 22:05
gnossen added a commit to gnossen/grpc that referenced this pull request Jan 14, 2021
Python Circuit Breaking Interop Test Client Additions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/test lang/Python release notes: no Indicates if PR should not be in release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants