Remove unnecessary working field from grpc_ares_ev_driver#25105
Merged
apolcyn merged 1 commit intogrpc:masterfrom Jan 13, 2021
Merged
Remove unnecessary working field from grpc_ares_ev_driver#25105apolcyn merged 1 commit intogrpc:masterfrom
apolcyn merged 1 commit intogrpc:masterfrom
Conversation
apolcyn
added
lang/core
release notes: no
This was referenced Mar 9, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently there's logic where we:
a) invoke
grpc_ares_ev_driver_start_lockedwhen a c-ares resolution beginsb) invoke
grpc_ares_ev_driver_start_lockedagain when the SRV query callback is invoked and the A/AAAA followups go out.And
grpc_ares_ev_driver_start_lockedhas thisworkingfield to apparently guard against its routine from happening again during b), if we don't need it to.However, all we need is to make sure that
grpc_ares_notify_on_event_locked(which is idempotent) gets called again after the A/AAAA SRV followup queries go out. And if the rest of the logic ingrpc_ares_ev_driver_start_lockedwere to somehow run again, it would be buggy due to re-initializing timers.