Move grpc_ares_ev_driver and fd_node into grpc_ares_wrapper.cc#25064
Merged
apolcyn merged 1 commit intogrpc:masterfrom Jan 6, 2021
Merged
Move grpc_ares_ev_driver and fd_node into grpc_ares_wrapper.cc#25064apolcyn merged 1 commit intogrpc:masterfrom
apolcyn merged 1 commit intogrpc:masterfrom
Conversation
apolcyn
added
lang/core
release notes: no
markdroth
approved these changes
Jan 6, 2021
Member
markdroth
left a comment
markdroth
left a comment
There was a problem hiding this comment.
Thanks for doing this! The c-ares resolver is the last part of the client channel code that hasn't yet been converted to C++, so it will be great to see this done!
Reviewed 19 of 19 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My eventual plan is to merge the
grpc_ares_requestandgrpc_ares_ev_drivertypes into a single C++ type.This PR gets some initial code motion out of the way. There are no functional changes, except for deleting the
grpc_ares_ev_driver_get_channel_lockedAPI, since it's no longer needed and is trivial to remove.grpc_ares_ev_driver.hfile is now used only forGrpcPolledFdand related types.