Only enable OpenSSL Engine when compiler supports it#24959
Merged
jiangtaoli2016 merged 1 commit intogrpc:masterfrom Dec 10, 2020
Merged
Only enable OpenSSL Engine when compiler supports it#24959jiangtaoli2016 merged 1 commit intogrpc:masterfrom
jiangtaoli2016 merged 1 commit intogrpc:masterfrom
Conversation
jiangtaoli2016
added
release notes: no
Author
|
fixing #21974 |
Author
|
This is similar to another bug we recent had that TLS1_3_VERSION was not defined, then causing handshaker failure. |
markdroth
approved these changes
Dec 10, 2020
Member
markdroth
left a comment
markdroth
left a comment
There was a problem hiding this comment.
Can we put together a test framework to catch this kind of problem?
Author
|
I asked your team 2 years back to set up test framework on various versions/builds of SSL libraries. Shall we re-visit? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@nicolasnoble