Separate out ref counted related logs from the xds_client logs#24949
Merged
donnadionne merged 3 commits intogrpc:masterfrom Dec 10, 2020
Merged
Separate out ref counted related logs from the xds_client logs#24949donnadionne merged 3 commits intogrpc:masterfrom
donnadionne merged 3 commits intogrpc:masterfrom
Conversation
donnadionne
added
the
release notes: no
markdroth
reviewed
Dec 9, 2020
Member
markdroth
left a comment
markdroth
left a comment
There was a problem hiding this comment.
Just one comment, otherwise looks great!
src/core/ext/xds/xds_client.cc
Outdated
| namespace grpc_core { | ||
|
|
||
| TraceFlag grpc_xds_client_trace(false, "xds_client"); | ||
| TraceFlag grpc_xds_client_ref_count_trace(false, "xds_client_ref_count"); |
Member
There was a problem hiding this comment.
Please change "ref_count" to "refcount", since this will allow this tracer to be enabled/disabled all at once with the other ref-count tracers. For context, see:
grpc/src/core/lib/debug/trace.cc
Line 51 in 0dd3f7e
(In https://github.com/grpc/grpc/blob/master/doc/environment_variables.md, we document the fact that you can enable all refcount tracers with "refcount".)
Contributor
Author
There was a problem hiding this comment.
I see! Fixed. PTAL thank you!
markdroth
approved these changes
Dec 10, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.