[Aio] Correct type annotation of grpc.aio.ServicerContext.abort#24946
Merged
lidizheng merged 1 commit intogrpc:masterfrom Dec 9, 2020
Merged
[Aio] Correct type annotation of grpc.aio.ServicerContext.abort#24946lidizheng merged 1 commit intogrpc:masterfrom
lidizheng merged 1 commit intogrpc:masterfrom
Conversation
lidizheng
added
lang/Python
release notes: yes
lidizheng
force-pushed
the
abort-annotation
branch
from
ca70099 to
45b4608
Compare
gnossen
approved these changes
Dec 9, 2020
Contributor
Author
|
Known Failure: #24947 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related #24942
grpc.aio.ServicerContext.abortaccepts 3 arguments, code, details, trailing metadata. And only the first argument code is positional without default value. This is howgrpc.aio.ServicerContextis implemented in Cython and tested in unit tests. But I overlooked this issue when I created the abstract class.