Fix overpermissive percent-decoding of URIs ('%eth1' case)#24941
Merged
drfloob merged 1 commit intogrpc:masterfrom Dec 9, 2020
Merged
Conversation
drfloob
added
the
release notes: no
markdroth
approved these changes
Dec 9, 2020
Invalid `%nn` 3-character strings were being incorrectly decoded. For example, in `%eth1`, the `%e` was being translated to ASCII 14, while the correct behavior is to leave `%eth1` unchanged since the string `%et` is an invalid 3-character percent encoding.
drfloob
force-pushed
the
fix-uri-parser-overpermissive-invalid-percent-decoding
branch
from
e882e85 to
6cc1d2e
Compare
Member
Author
|
The MacOS artifact build failure is not related to this work, and it's being investigated separately. I'm merging this PR given that all other tests pass. |
drfloob
deleted the
fix-uri-parser-overpermissive-invalid-percent-decoding
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Invalid
%nn3-character strings were being incorrectly decoded. Forexample, in
%eth1, the%ewas being translated to ASCII 14, whilethe correct behavior is to leave
%eth1unchanged since the string%etis an invalid 3-character percent encoding.@markdroth