Fix implicit-int-float-conversion warning.#24775
Merged
jtattermusch merged 1 commit intogrpc:masterfrom Feb 11, 2021
PatriosTheGreat:master
Merged
Fix implicit-int-float-conversion warning.#24775jtattermusch merged 1 commit intogrpc:masterfrom PatriosTheGreat:master
jtattermusch merged 1 commit intogrpc:masterfrom
PatriosTheGreat:master
Conversation
|
|
Contributor
|
Can you please sign the CLA before we can review this PR @PatriosTheGreat ? |
karthikravis
approved these changes
Nov 23, 2020
karthikravis
added
the
release notes: no
Contributor
|
Can you please run "tools/distrib/clang_tidy_code.sh" and fix the issue? This is the only blocker for the PR to be merged now. Thanks! |
Contributor
|
@veblush FYI |
jtattermusch
approved these changes
Feb 11, 2021
Contributor
jtattermusch
left a comment
jtattermusch
left a comment
There was a problem hiding this comment.
I've looked at the test failures and they all seem to be infrastructure related problems (e.g. windows kokoro jobs timing out) - otherwise this PR seems like it's good to go.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clang 10 and above warm implicit cast from int to float, or double in this case.
@karthikravis