+1

On Wed, Jul 15, 2015, 5:07 PM Michael Lumish [email protected]
wrote:

This replaces the existing two-phase server construction with creating a
server object and then attaching service/implementation pairs to it. Also
changes start to listen, because that more clearly indicates what it does.

This resolves #2456 #2456.

You can view, comment on, or merge this pull request online at:

#2464
Commit Summary

• Changed to newer, simpler server construction interface

File Changes

• M src/node/README.md
  https://github.com/grpc/grpc/pull/2464/files#diff-0 (4)
• M src/node/examples/math_server.js
  https://github.com/grpc/grpc/pull/2464/files#diff-1 (18)
• M src/node/examples/route_guide_server.js
  https://github.com/grpc/grpc/pull/2464/files#diff-2 (16)
• M src/node/examples/stock_server.js
  https://github.com/grpc/grpc/pull/2464/files#diff-3 (15)
• M src/node/index.js
  https://github.com/grpc/grpc/pull/2464/files#diff-4 (6)
• M src/node/interop/interop_server.js
  https://github.com/grpc/grpc/pull/2464/files#diff-5 (20)
• M src/node/src/server.js
  https://github.com/grpc/grpc/pull/2464/files#diff-6 (183)
• M src/node/test/health_test.js
  https://github.com/grpc/grpc/pull/2464/files#diff-7 (9)
• M src/node/test/interop_sanity_test.js
  https://github.com/grpc/grpc/pull/2464/files#diff-8 (2)
• M src/node/test/math_client_test.js
  https://github.com/grpc/grpc/pull/2464/files#diff-9 (2)
• M src/node/test/surface_test.js
  https://github.com/grpc/grpc/pull/2464/files#diff-10 (192)

Patch Links:

• https://github.com/grpc/grpc/pull/2464.patch
• https://github.com/grpc/grpc/pull/2464.diff

—
Reply to this email directly or view it on GitHub
#2464.

I added the change that replaces a server-wide metadata handlers with the ability for individual handers to send metadata.

Awesome 👍