Allow grpcio to be built against system re2#24450
Conversation
gnossen
left a comment
There was a problem hiding this comment.
👍 Thanks for the fix! Keeping these sorts of build features working is tricky, so we depend on downstream users to make sure they keep on working. 🙂
Out of curiosity, since I've seen at least one other PR from you, are you vendoring gRPC for a distro or something?
|
CC @lidizheng for a second pair of eyes. |
|
@mtorromeo The code formatter is complaining: Can you please run |
Yes, I am maintaining the Arch Linux package.
The script doesn't work as-is on Arch since Anyway I ran it after fixing it but it's also changing the format of I force pushed the amended commit with the fixed setup.py and ignored the changes in other files. |
Nice! I thought your name looked familiar. I use your package on my personal machine at home. I've commented in the past how the Arch package somehow gets published before we get our package up on PyPi. |
The main grpc library can be built with system re2 using the cmake flag
-DgRPC_RE2_PROVIDER=package. This brings the grpcio package in line with grpc using similar checks and env variables used forBUILD_WITH_SYSTEM_CARES/OPENSSL/ZLIB.@donnadionne