Make Python 2 an optional dependency for Bazel build#24407
Merged
gnossen merged 3 commits intogrpc:masterfrom Oct 16, 2020
Merged
Make Python 2 an optional dependency for Bazel build#24407gnossen merged 3 commits intogrpc:masterfrom
gnossen merged 3 commits intogrpc:masterfrom
Conversation
gnossen
added
infra/Bazel
kind/enhancement
lang/Python
release notes: yes
gnossen
changed the title
lidizheng
approved these changes
Oct 15, 2020
Contributor
lidizheng
left a comment
lidizheng
left a comment
There was a problem hiding this comment.
LGTM! Are users asking for this feature?
Contributor
Author
|
Yes, the users I mentioned this morning were having trouble getting Python 2 installed in build environments that otherwise didn't need it. |
Contributor
Author
|
Known failures:
We should probably add some retries in there. |
|
Hi, did this land in v1.34.0? I am still getting python_configure errors building in an Cheers, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes a Python 2 runtime with headers an optional dependency for Bazel builds. In case no proper Python 2 environment is detected, we create a rule like
This empty
filegrouprule passes the analysis phase, but will fail during the build phase of any Python 2 targets, which are all test targets within our repo, and which downstream repos will not be touching.This will also be backported to 1.33.