RBE: rely on labels to select the right worker pool (instead of hardcoding GCE machine types)#24370
Merged
jtattermusch merged 2 commits intogrpc:masterfrom Oct 12, 2020
Merged
Conversation
Contributor
Author
Contributor
Author
|
@rubensf feel free to review the workaround I used for setting the RBE worker pool labels. I know it's a bit dirty, but it seems to work just fine and considering the challenges I mentioned in the PR description I think it's actually a pretty clever solution to solve the problem we're having (and to expedite the E2 migration). |
rubensf
reviewed
Oct 9, 2020
rubensf
left a comment
There was a problem hiding this comment.
LGTM - this should work fine! Thanks for looking into this 👍
gnossen
approved these changes
Oct 12, 2020
Contributor
gnossen
left a comment
There was a problem hiding this comment.
Very clever workaround! 👍
Contributor
Author
|
Known failures: #24375 |
This was referenced Oct 13, 2020
jtattermusch
added a commit
that referenced
this pull request
Oct 14, 2020
Backport #24370 to v1.33.x
nicolasnoble
added a commit
that referenced
this pull request
Oct 14, 2020
Backport #24370 to v1.32.x
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation: we want to switch our RBE worker pools from n1 instances to e2 instances. The problem is that currently our RBE configuration relies on hardcoded machine types (e.g.
n1-standard-8) to determine on which worker pool should a given test run (there are 2 linux pools, one with 8core "large" machines and one with 2core "small" machines; there is also a windows pool. Tests need to run on the right pools to avoid unexpected failures.Challenges:
This PR represents an approach that seems to work and that would allow us to switch our existing worker pools to e2 instances seamlessly without breaking the world (and it can be backported to older branches as needed).