Revert "Revert "Allow asyncio API to be imported as grpc.aio""#24341
Merged
Revert "Revert "Allow asyncio API to be imported as grpc.aio""#24341
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #24337
Original #24289
Fixes #24281
Internally, the OSS gRPC module is renamed to "_open_source_grpc", and will be imported in 2 steps: the import hack, the actual import. Checking package name works in this case.
If we use open source mode internally, the OSS gRPC module name stays "grpc", but still it will be imported in 2 steps: a no-op import, the actual import. The tests failed because the "aio" module tried to initiate itself after the "no-op" import and found "grpc" module to be empty.
So, the (brutal-force) solution is to check the file name to ensure when the import hack happened, don't import "aio" module in this file. The import of "aio" module will happen in the magical
__init__.py(cl/335754366).