Removing TLS workaround for Android NDK r12b#24283
Merged
veblush merged 1 commit intogrpc:masterfrom Oct 7, 2020
Merged
Conversation
veblush
added
area/build
release notes: yes
ericgribkoff
approved these changes
Oct 1, 2020
Contributor
ericgribkoff
left a comment
ericgribkoff
left a comment
There was a problem hiding this comment.
LGTM, but we should get a green build of the android job before merging
Contributor
Author
|
@ericgribkoff Thanks! I'll do. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dropping the workaround for Android NDK r12b to simplify TLS implementation and r12b (released in 2016) is old enough to drop.
This is a prerequisite for #24247 and this PR can be merged after the 1.33 release cut (Oct 6)