Pass address to CreateSubchannel() and expose attributes in SubchannelInterface.#24172
Merged
markdroth merged 1 commit intogrpc:masterfrom Sep 18, 2020
Merged
Pass address to CreateSubchannel() and expose attributes in SubchannelInterface.#24172markdroth merged 1 commit intogrpc:masterfrom
markdroth merged 1 commit intogrpc:masterfrom
Conversation
markdroth
added
the
release notes: no
markdroth
force-pushed
the
subchannel_address
branch
from
3553746 to
c37bfb4
Compare
markdroth
force-pushed
the
subchannel_address
branch
from
c37bfb4 to
f7a72b0
Compare
donnadionne
approved these changes
Sep 18, 2020
Member
Author
|
Known issue: #23933 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will be needed for the affinity design. It's also a nice cleanup, which allowed me to move a bunch of channel args manipulation code from subchannel_list.h into client_channel.cc, which is where it belongs. And in a subsequent PR, I will use this to fix a long-standing bug in grpclb.