Merged
Conversation
veblush
added
kind/enhancement
area/test
lang/core
release notes: no
yang-g
approved these changes
Sep 17, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
TestGrpcScopeto control timing for gRPC init and shutdown. This is developed forbm_opencensuswhich needs to configure gRPC before init to run test with or without census. Previouslybm_opencensusused to callTestEnvironmentwithout argv multiple times but this is not right because i)TestEnvironmentis not designed to be called several times and ii) having null argv happened to be safe but not anymore.